Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition for #12563, Add parameter check for tag. #12575

Merged

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Addition for #12563, Add parameter check for tag.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Sep 2, 2024
@KomachiSion KomachiSion added this to the 2.4.2 milestone Sep 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.65%. Comparing base (5ded85f) to head (9778110).

Files with missing lines Patch % Lines
.../alibaba/nacos/config/server/utils/ParamUtils.java 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12575      +/-   ##
=============================================
+ Coverage      69.63%   69.65%   +0.02%     
- Complexity      9407     9411       +4     
=============================================
  Files           1275     1275              
  Lines          41180    41203      +23     
  Branches        4370     4371       +1     
=============================================
+ Hits           28674    28701      +27     
+ Misses         10427    10420       -7     
- Partials        2079     2082       +3     
Files with missing lines Coverage Δ
.../remote/ConfigChangeBatchListenRequestHandler.java 85.71% <100.00%> (+0.71%) ⬆️
.../remote/ConfigChangeClusterSyncRequestHandler.java 100.00% <100.00%> (ø)
...onfig/server/remote/ConfigQueryRequestHandler.java 86.84% <100.00%> (+0.35%) ⬆️
...server/service/dump/disk/ConfigRawDiskService.java 82.45% <100.00%> (+2.25%) ⬆️
.../alibaba/nacos/config/server/utils/ParamUtils.java 68.88% <66.66%> (+2.22%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ded85f...9778110. Read the comment docs.

@KomachiSion KomachiSion merged commit 197347f into alibaba:develop Sep 2, 2024
7 checks passed
@KomachiSion KomachiSion deleted the upstream-develop-check-param branch September 2, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants