Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12168] 修复系统语言切换至英文后,权限控制-角色管理页面的查询条件的label还显示的是中文 #12169

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

misakacoder
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#12168

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@misakacoder misakacoder closed this Jun 3, 2024
@misakacoder misakacoder reopened this Jun 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.77%. Comparing base (07d92ff) to head (3bffc4d).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12169      +/-   ##
=============================================
- Coverage      68.81%   68.77%   -0.04%     
  Complexity      9230     9230              
=============================================
  Files           1264     1264              
  Lines          41183    41183              
  Branches        4361     4361              
=============================================
- Hits           28339    28323      -16     
- Misses         10808    10827      +19     
+ Partials        2036     2033       -3     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d92ff...3bffc4d. Read the comment docs.

@KomachiSion KomachiSion merged commit 8a03485 into alibaba:develop Jun 3, 2024
13 checks passed
@KomachiSion KomachiSion added area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug. labels Jun 3, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants