[ISSUE #11926] The abnormal exit mechanism does not take effect #11999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KomachiSion
previously approved these changes
Apr 23, 2024
|
Continuous Integration/CI (Ubuntu latest, 8) results： Can the local test pass, but Continuous Integration/CI (Ubuntu latest, 8) cannot? |
|
Please rebase from develop branch， the ut problem has been fixed |
…lakeInstanceIdGenerator初始化流程 (alibaba#11995) * [ISSUE alibaba#11994] fix: Initialize EnvUtil's variable environment in HttpRequestInstanceBuilderTest * refactor: Optimize the initialization process of SnowFlakeInstanceIdGenerator * refactor: optimize the initialization process of SnowFlakeInstanceIdGenerator.
…dule. (alibaba#11996) * Move some basic logging classes into common module. * Move logback 12 version adapter to single module. * For checkstyle. * Enhance logger adapter pom. * Refactor the adapter initialization logic to avoid spi loader error. * Move log4j2 logger adapter to single module. * Fix the ut cover and create useless dir.
* Remove log4j dependencies from nacos-client. * Fix logback listener don't add to context. * Fix can't adapter low version logback below 1.1.10. * For checkstyle.
Okay |
|
The Pr include others commit, please fix it. If you can't, I suggest you checkout from develop branch and cherry-pick your commit into new branch and submit new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix #11926 The abnormal exit mechanism does not take effect