Response wrong status code for some situation for openAPI

[publicize-y]

link #11842

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.61%. Comparing base (b79d585) to head (fcf9982).
Report is 8 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #11864      +/-   ##
=============================================
+ Coverage      67.91%   68.61%   +0.69%     
- Complexity      8915     9027     +112     
=============================================
  Files           1236     1239       +3     
  Lines          40459    40584     +125     
  Branches        4292     4317      +25     
=============================================
+ Hits           27479    27845     +366     
+ Misses         11003    10746     -257     
- Partials        1977     1993      +16     

Files	Coverage Δ
...onfig/server/exception/GlobalExceptionHandler.java	33.33% <100.00%> (+33.33%)	⬆️
...cos/console/exception/ConsoleExceptionHandler.java	28.57% <100.00%> (+28.57%)	⬆️
...os/console/exception/NacosApiExceptionHandler.java	15.38% <100.00%> (+15.38%)	⬆️
...cos/naming/exception/ResponseExceptionHandler.java	25.00% <100.00%> (+25.00%)	⬆️
...theus/exception/PrometheusApiExceptionHandler.java	66.66% <100.00%> (+66.66%)	⬆️

... and 28 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b79d585...fcf9982. Read the comment docs.

[KomachiSion]

Can you help add some unit test？

[publicize-y]

ok，I will add

[publicize-y]

ok，I will add

[publicize-y]

I would like to ask if there is already a NacosRuntimeExceptionTest. Is the unit test you mentioned specifically for defect # 11842

[publicize-y]

@KomachiSion

[KomachiSion]

You change the code in many XXXExceptionHandler.java, so you should add some unit test to test you add or change logic is work well not relative NacosRuntimeExceptionTest.

[publicize-y]

Why does my unit test affect other unit tests? I would like to seek help. This is my first PR @KomachiSion

[KomachiSion]

I retry the ci with several times, but every time can't pass with UdpConnectorTest.

It might some UT you added affect the UdpConnectorTest so that it can't pass, I will try it last time, if can't pass again with UdpConnectorTest, it should be fixed in this PR by you. Thanks.

[KomachiSion]

From the old information, some mock in UdpConnectorTest is marked useless, maybe you added UT has init some static variable and make the UdpConnectorTest mock useless.

If last time retry still failed by this reason, I suggest you see the error info and find out which mock is marked useless, and to make UT use the mock.

[publicize-y]

Can I modify the UdpConnectorTest class？

[publicize-y]

and I want to know if the logic of my unit testing is correct @KomachiSion

[KomachiSion]

Can I modify the UdpConnectorTest class？

How do you want to modify it?

[KomachiSion]

and I want to know if the logic of my unit testing is correct @KomachiSion

Your UT logic is ok, but you use WebMvc to start ut, the WebMvc will build the mock spring container, and spring container will build some bean and static variable.

When bean and static variable mock build by WebMvc and before UdpConnectorTest, it might cause mock in UdpConnectorTest not be used.

[publicize-y]

and I want to know if the logic of my unit testing is correct @KomachiSion

Your UT logic is ok, but you use WebMvc to start ut, the WebMvc will build the mock spring container, and spring container will build some bean and static variable.

When bean and static variable mock build by WebMvc and before UdpConnectorTest, it might cause mock in UdpConnectorTest not be used.

Is there a better way not to use mockmvc? I'm trying other methods. The bean in the container does not have xxxxexceptionHandler, which makes it unable to handle exceptions

[publicize-y]

and I want to know if the logic of my unit testing is correct @KomachiSion

Your UT logic is ok, but you use WebMvc to start ut, the WebMvc will build the mock spring container, and spring container will build some bean and static variable.
When bean and static variable mock build by WebMvc and before UdpConnectorTest, it might cause mock in UdpConnectorTest not be used.

Is there a better way not to use mockmvc? I'm trying other methods. The bean in the container does not have xxxxexceptionHandler, which makes it unable to handle exceptions

and currently, I have not found any unit tests for exception handling classes in the source code of Nacos

[shalk]

@publicize-y

You can just remove the webmvc

[publicize-y]

@publicize-y

You can just remove the webmvc

Thks