Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#11752): The contentPath of AddressServerUrl is not flexible. #11754

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Bo-Qiu
Copy link
Contributor

@Bo-Qiu Bo-Qiu commented Feb 19, 2024

What is the purpose of the change

feat(#11752 ): The contentPath of AddressServerUrl is not flexible.

Brief changelog

feat(#11752 ): The contentPath of AddressServerUrl is not flexible.

Verifying this change

feat(#11752 ): The contentPath of AddressServerUrl is not flexible.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the ServerListManager in client/naming/package?

@Bo-Qiu
Copy link
Contributor Author

Bo-Qiu commented Feb 29, 2024

How about the ServerListManager in client/naming/package?

I changed it, please review it again, thx!

@KomachiSion KomachiSion merged commit 4397e8d into alibaba:develop Mar 7, 2024
7 checks passed
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Client Related to Nacos Client SDK labels Mar 7, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone Mar 7, 2024
@Bo-Qiu Bo-Qiu deleted the feat/11752 branch April 1, 2024 03:29
@KomachiSion KomachiSion modified the milestones: 2.4.0, 2.3.2 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants