-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]disk failover datasource not keep status #12207
Comments
so should we change the judgement but not add an status to keep this way? |
when lastModifiedMillis == modified , we do not know what is lastSwitch ? what is your opinion ? |
OK, I know what's your mean, I think your change is a way to fix this problem. Or we reuse the If |
Yes , |
Describe the bug
I try to use client discovery feature "failover on disk ", when create failover switch file
00-VIP-SWICH-...
.The client log print
failover-mode is on
, a few second later, log printfailover switch changed, new: off
Because in DiskFailoverDataSource, switch file is not change, so lastModifiedMillis == modified and
return new FailoverSwitch(Boolean.FALSE);
I think this is bug in early pr, i will fix it.
Expected behavior
expect failover switch is alway on
Actually behavior
failover switch is off at last
How to Reproduce
Steps to reproduce the behavior:
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: