feat: improve miniapp #6985
Open
feat: improve miniapp #6985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
XGHeaven
force-pushed
the
feat/miniapp
branch
8 times, most recently
from
3a99204
to
8a12b36
Compare
XGHeaven
force-pushed
the
feat/miniapp
branch
4 times, most recently
from
1dc7df9
to
6ae900b
Compare
XGHeaven
force-pushed
the
feat/miniapp
branch
from
6ae900b
to
d181d35
Compare
XGHeaven
force-pushed
the
feat/miniapp
branch
2 times, most recently
from
422ac13
to
23d428d
Compare
XGHeaven
force-pushed
the
feat/miniapp
branch
4 times, most recently
from
4a9c48d
to
67c1295
Compare
XGHeaven
force-pushed
the
feat/miniapp
branch
from
67c1295
to
0a806a9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6985 +/- ##
==========================================
+ Coverage 79.08% 79.09% +0.01%
==========================================
Files 221 220 -1
Lines 19715 19654 -61
Branches 2506 2508 +2
==========================================
- Hits 15592 15546 -46
+ Misses 4085 4068 -17
- Partials 38 40 +2 ☔ View full report in Codecov by Sentry. |
XGHeaven
force-pushed
the
feat/miniapp
branch
2 times, most recently
from
441c21c
to
13f7a02
Compare
|
CI 的问题可以先解决了 |
XGHeaven
force-pushed
the
feat/miniapp
branch
from
13f7a02
to
d5bbec3
Compare
|
@ClarkXia CI 已经解决了 |
ClarkXia
reviewed
Oct 29, 2024
| "@ice/shared-config": "1.2.9", | ||
| "@ice/webpack-config": "1.1.16", | ||
| "@ice/rspack-config": "1.1.10", | ||
| "@ice/bundles": "workspace:*", |
There was a problem hiding this comment.
一些工程依赖包的策略上是锁版本的，使用 workspace 没法保证发布后的版本规则吧？
| @@ -11,7 +11,7 @@ export const isKuaiShouMiniProgram = isClient && import.meta.target === 'kuaisho | |||
| export const isWeChatMiniProgram = isClient && import.meta.target === 'wechat-miniprogram'; | |||
| export const isKraken = isClient && import.meta.target === 'kraken'; | |||
| export const isQuickApp = false; // Now ice.js will not implement quick app target. | |||
| export const isMiniApp = isAliMiniApp || isByteDanceMicroApp || isBaiduSmartProgram || isKuaiShouMiniProgram || isWeChatMiniProgram; | |||
| export const isMiniApp = isAliMiniApp;// in universal-env, isMiniApp is equals to isAliMiniApp | |||
| @@ -317,6 +321,17 @@ export function createRoutePath(routeId: string): string | undefined { | |||
| return result || undefined; | |||
| } | |||
|
|
|||
| function createRouteIdStripIndex(page: string): string { | |||
There was a problem hiding this comment.
routeMainfest 的 path 字段应该也是类似逻辑，看下是不是应该是一致的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.