Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use the same compiler when build data-loader #6804

Merged
merged 9 commits into from
Mar 19, 2024

Conversation

ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Feb 22, 2024

  • Compile data-loader in request time when dev
  • Compile parallelly when build

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 58.95954% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 79.35%. Comparing base (511bfbc) to head (78a9d0e).
Report is 7 commits behind head on release/next.

Files Patch % Lines
packages/ice/src/bundler/rspack/getConfig.ts 20.40% 39 Missing ⚠️
packages/ice/src/bundler/rspack/index.ts 20.68% 23 Missing ⚠️
packages/ice/src/bundler/config/middlewares.ts 50.00% 5 Missing ⚠️
...ckages/ice/src/middlewares/dataLoaderMiddleware.ts 94.11% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/next    #6804      +/-   ##
================================================
- Coverage         79.57%   79.35%   -0.23%     
================================================
  Files               219      220       +1     
  Lines             19452    19603     +151     
  Branches           2506     2509       +3     
================================================
+ Hits              15478    15555      +77     
- Misses             3938     4012      +74     
  Partials             36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from release/next to master February 26, 2024 06:27
@ClarkXia ClarkXia changed the base branch from master to release/next February 26, 2024 06:43
@ClarkXia ClarkXia changed the title [WIP] Refactor: use the same compiler when build data-loader Refactor: use the same compiler when build data-loader Feb 27, 2024
luhc228
luhc228 previously approved these changes Mar 5, 2024
Base automatically changed from release/next to master March 7, 2024 05:26
@ClarkXia ClarkXia changed the base branch from master to release/next March 7, 2024 07:43
@ClarkXia ClarkXia requested a review from luhc228 March 11, 2024 03:17
@ClarkXia ClarkXia removed the need review Need Review label Mar 11, 2024
@ClarkXia ClarkXia merged commit 0d3cfd5 into release/next Mar 19, 2024
7 checks passed
@ClarkXia ClarkXia deleted the feat/compile-data-loader branch March 19, 2024 06:04
@ClarkXia ClarkXia mentioned this pull request Mar 19, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants