fix: use getBoundingClientRect to get the exact size
#2482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
crazylxr
reviewed
Feb 23, 2024
| @@ -24,8 +23,8 @@ function useSize(target: BasicTarget): Size | undefined { | |||
|
|
|||
| const resizeObserver = new ResizeObserver((entries) => { | |||
| entries.forEach((entry) => { | |||
| const { clientWidth, clientHeight } = entry.target; | |||
There was a problem hiding this comment.
不能这么改，clientWidth 和 getBoundingClientRect 的 width 是有差别的，clientWidth 是不包含border 的，width 是包含的，这样改会有 break change
There was a problem hiding this comment.
👌，那可以考虑加一个 useBoundingClientRect hook？
There was a problem hiding this comment.
👌，那可以考虑加一个
useBoundingClientRecthook？
v4 大版本考虑一下怎么把这些相关的统一一下，这个 pr 我先 close 了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
useSizeUsegetBoundingClientRectto get the exact size #2481💡 Background and solution
📝 Changelog
☑️ Self Check before Merge