Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: createUseStorageState support hook state sync between some tabs #1580

Closed
wants to merge 3 commits into from

Conversation

ruoruoji
Copy link

@ruoruoji ruoruoji commented May 3, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  1. I found the hook state from one tab not update,while i using the same hook instance from another tab.
  2. use storage addEventListener to receive update from another tab

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


孙权 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ruoruoji ruoruoji changed the title feat: support hook state sync between tabs feat: createUseStorageState support hook state sync between some tabs May 3, 2022
@brickspert
Copy link
Collaborator

Current changes do not solve all problems, like this:
https://stackoverflow.com/questions/35865481/storage-event-not-firing

@ruoruoji
Copy link
Author

ruoruoji commented May 5, 2022

Current changes do not solve all problems, like this: https://stackoverflow.com/questions/35865481/storage-event-not-firing

dispatch store event after setState to handle the same tab problem, it will fire the linster although it made from the same hook instance. i think it's not a problem.

but i know little about jest, so test case will be a problem.
image

@liuyib liuyib self-requested a review March 11, 2023 09:49
@liuyib
Copy link
Collaborator

liuyib commented Aug 20, 2023

this will be solved in #2298, so closed

@liuyib liuyib closed this Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants