fix(utils): adjust the order of getting self #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stkevintan
reviewed
Jul 18, 2019
| @@ -2,7 +2,8 @@ import { isFn } from '@uform/types' | |||
|
|
|||
| type Filter = (value: any, key: string) => boolean | |||
|
|
|||
| const self: { [key: string]: any } = window || global || this | |||
| const _self: { [key: string]: any } = | |||
| self || window || global || Function('return this')() | |||
|
|
|||
| const NATIVE_KEYS = [ | |||
There was a problem hiding this comment.
NATIVE_KEYS: [string, (obj: any) => any][] = [xxxx]下面就不用as了
There was a problem hiding this comment.
好像这样子也是不行的哦，他是有 string 类型的
NATIVE_KEYS: ([string, (obj: any) => any] | string)[] = [xxxx]这样子解有点问题，下面去掉 as string ，也是会报错。
stkevintan
reviewed
Jul 18, 2019
| self[item[0] as string] && | ||
| values instanceof self[item[0] as string] | ||
| _self[item[0] as string] && | ||
| values instanceof _self[item[0] as string] | ||
| ) { | ||
| return item[1] ? item[1] : item[0] | ||
| } | ||
| } else { |
|
@stkevintan 我先 merge 了，因为这个涉及的影响有点多，算是比较紧急的问题。后面要是有问题再说，特别是 ts 的话可以新开另外一个 PR哈。 |
ZirkleTsing
pushed a commit
that referenced
this pull request
May 14, 2020
* fix(utils): adjust the order of getting self * refactor: imitate globalThis * refactor: polyfill globalThis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #177
调整下获取全局变量的优先级，不然 this 在 webpack 打包的时候运行时会变成 module