Skip to content

Commit

Permalink
chore(grid): improve resolveChildren
Browse files Browse the repository at this point in the history
  • Loading branch information
janryWang committed Nov 22, 2021
1 parent 342493a commit 024a74f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion packages/grid/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ const resolveChildren = (grid: Grid<HTMLElement>) => {
rowIndex = 0
if (!grid.ready) return
grid.children = grid.children.map((node) => {
if (!node.visible) return node
const columnIndex = walked % grid.columns
const remainColumns = grid.columns - columnIndex
const originSpan = node.originSpan
Expand Down

2 comments on commit 024a74f

@Nokecy
Copy link
Contributor

@Nokecy Nokecy commented on 024a74f Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个提交破坏了 gridSpan = -1 的行为 ,在查询表单展开收起操作时,如果想收起时,操作按钮和输入组件在一行,这里隐藏的元素还计算列,那么最后操作按钮的gridColumn 计算错误了 @janryWang

@janryWang
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单独提discussion吧,把codesandbox放出来看看

Please sign in to comment.