-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[connector] flink read support for fluss primary key table changelog auxiliary table/ cdc events #510
base: main
Are you sure you want to change the base?
[connector] flink read support for fluss primary key table changelog auxiliary table/ cdc events #510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MehulBatra , the direction looks good to me. I left some comments. Looking forward to a complete pull request!
Some tips for the following:
- Add comprehensive tests for the feature, including
FlinkCatalogTest
for verifying the catalog table information- integration tests in
FlinkTableSourceITCase
to support reading all columns,partial columns, partial metadata columns. - tests to verify the
$changelog
doesn't support as a sink table. - etc.
- We may also need to adapt the
FlinkTableSource
to make it works with existing pushdown optimizations.
fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorService.java
Outdated
Show resolved
Hide resolved
...ector-flink/src/main/java/com/alibaba/fluss/connector/flink/utils/ChangelogRowConverter.java
Outdated
Show resolved
Hide resolved
...ector-flink/src/main/java/com/alibaba/fluss/connector/flink/utils/ChangelogRowConverter.java
Outdated
Show resolved
Hide resolved
...ss-connector-flink/src/main/java/com/alibaba/fluss/connector/flink/catalog/FlinkCatalog.java
Outdated
Show resolved
Hide resolved
… validateTableDescriptor, attaching additonal columns & using Joinedrowdata
Resolved the comments, made on the particular code blocks. Will start with this now! |
…upport for changelog table
|
@wuchong Could you please help me with reviewing this PR |
Contribution Checklist
Purpose
Enhanced the Flink connector by introducing support for the $changelog auxiliary table. enabling seamless CDC event capture and processing in streaming applications
Brief change log
Tests
Yet to write (In progress)
API and Format
Yes , Flink Source Reader
Documentation
Yes post feedback need to add changes in the doc to support CDC reads via Flink Connector