Improve getObject support, fixed #3302,#3340,#3393 #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marked overridden method with @OverRide annotation Catch checkException
|
|
|
@JasonMing 修复了，在master分支。最新的1.1.20版并没有将修复的代码一起发布，所以只能等作者发布新版 |
|
@yidasanqian 真是心碎啊，我暂时换hikari了。。。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复上版本未完全修复的bug #3302,#3340,#3393
相关覆盖方法添加
@Override注解相关方法捕获处理
checkException异常还有一个建议是：可以对全库的代码的行分隔符做一个统一格式化，Unix/Linux使用的是LF，Mac也是LF，但Windows是CRLF，推荐格式化为LF，可以避免Git自动转换换行符导致整个文件被修改的尴尬情况。