Fix:修复logFile路径在window中展示的问题以及RenderUtil.render方法StackOverflow的问题 #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…webconsole-fix
sheepblueblue
changed the title
|
两个不同功能的修改，不要在一个PR里提交哈，需要拆分为不同PR。 CharSlicer 在这个项目里， 不过好像修复过了。但这个忘记发版本了😂 alibaba/text-ui#3 |
好的，第一个问题我重新提一个PR。第二个stackoverflow error的问题我看了下已经修复的代码，思路和我是一样的，就是他的实现稍微啰嗦一点，那我就不提了吧😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
（1）修复logFile路径在Window中可能展示为：C:\Users\80280631/logs/arthas/arthas.log 的问题。
（2）修复RenderUtil的render方法可能抛出StackOverflow error的问题，因为CharSlicer类我在arthas项目里没有找到，我就新建了一个。#1908