FIX(arthas.core):修复javaagent指定arthas.properties路径加载错误 #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tszwang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
hengyunabc
reviewed
Jul 8, 2021
| @@ -299,7 +299,7 @@ private void tryToLoadArthasProperties() throws IOException { | |||
| String location = null; | |||
|
|
|||
| if (arthasEnvironment.containsProperty(CONFIG_LOCATION_PROPERTY)) { | |||
| location = arthasEnvironment.resolvePlaceholders(CONFIG_LOCATION_PROPERTY); | |||
There was a problem hiding this comment.
这里 resolvePlaceholders 是对的，只是需要改为
arthasEnvironment.resolvePlaceholders(arthasEnvironment.getProperty(CONFIG_LOCATION_PROPERTY));
还有另外一个 NAME 也需要这样子处理。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原bug，可以看到指定配置文件路径后，参数传递正常，但是通过resolvePlaceholders无法拿到路径。
故修改为arthasEnvironment.getProperty(CONFIG_LOCATION_PROPERTY); 之后便可以正常获取路径参数。