Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove env JAVA_TOOL_OPTIONS #1764

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

robberphex
Copy link
Contributor

很多APM工具、调试工具,都是通过设置环境变量 JAVA_TOOL_OPTIONS 来实现相关功能(比如Aliyun ARMSGCP Cloud Profiler)。
最终用户在通过./as.sh启动arthas时,也会加载APM agent。
但使用Arthas的人,即没有必要管理Arthas的性能、没有必要调试Arthas内部代码,这个行为也增加了arthas的启动时间。

所以在./as.sh脚本中,忽略JAVA_TOOL_OPTIONS环境变量,以便更快的启动、更方便的使用。

@hengyunabc
Copy link
Collaborator

java -jar arthas-boot.jar 启动的,同样会受这个影响不?

@robberphex
Copy link
Contributor Author

java -jar arthas-boot.jar 启动的,同样会受这个影响不?

java -jar启动,jvm会自动读取JAVA_TOOL_OPTIONS变量,arthas没法改变这一点。
这个pr会使脚本启动的时候,不加载JAVA_TOOL_OPTIONS。

@hengyunabc hengyunabc added this to the 3.5.1 milestone Apr 13, 2021
@hengyunabc hengyunabc merged commit 342c474 into alibaba:master Apr 13, 2021
@robberphex robberphex deleted the remove-java-tool-options branch April 13, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants