Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grouping dynamic inventory on security group bug #169

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Fix grouping dynamic inventory on security group bug #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
# Ansible-Alicloud Change Log
## 1.10.0 (Unreleased)

IMPROVEMENTS:

- Add creation_time attribute in ali_image_facts results ([#164](https://github.com/alibaba/ansible-provider/pull/164))

BUG FIXES:

- Fix grouping dynamic inventory on security group bug ([#165](https://github.com/alibaba/ansible-provider/pull/165))
- Default to describe all instances in all regions ([#158](https://github.com/alibaba/ansible-provider/pull/158))
- Fix ecs_instance_filters last page describe bug ([#157](https://github.com/alibaba/ansible-provider/pull/157))
- Fix ecs_instance_filters's page_size bug ([#156](https://github.com/alibaba/ansible-provider/pull/156))
Expand Down
2 changes: 1 addition & 1 deletion contrib/inventory/alicloud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ def add_instance(self, instance, region):

# Inventory: Group by security group
if self.group_by_security_group:
for group in instance.security_group_ids:
for group in instance.security_group_ids['security_group_id']:
key = self.to_safe("security_group_" + group)
self.push(self.inventory, key, hostname)
if self.nested_groups:
Expand Down