Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CONTRIBUTING.md #3346

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

robberphex
Copy link
Collaborator

Describe what this PR does / why we need it

Update CONTRIBUTING.md, describe how to run tests on different jdk version.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

CONTRIBUTING.md Outdated Show resolved Hide resolved
@robberphex robberphex force-pushed the update-CONTRIBUTING.md branch from d929b4b to c68e994 Compare February 22, 2024 03:43
Copy link
Collaborator

@LearningGp LearningGp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@panxiaojun233 panxiaojun233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp LearningGp merged commit 41569f9 into alibaba:1.8 Feb 27, 2024
8 checks passed
@robberphex robberphex deleted the update-CONTRIBUTING.md branch February 27, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants