Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard support resource regex match #3304

Closed

Conversation

wangxiaof
Copy link

@wangxiaof wangxiaof commented Jan 10, 2024

Describe what this PR does / why we need it

Resource rules (flow/degrade/param/authority) support regex match

Does this pull request fix one issue?

#3303

Describe how you did it

dashboard frontend: tips support regex match
dashboard backend:(flow/degrade/param/authority)Entity add a regex field and support user choice on dashboard

Describe how to verify it

1、check (flow/degrade/param/authority) value of regex in memory

Special notes for reviews

this is a my first pr.

@wangxiaof wangxiaof changed the title dashbord support resource regex dashboard support resource regex Jan 10, 2024
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ wangxiaof
❌ xiaofeiwang


xiaofeiwang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@LearningGp LearningGp added to-review To review area/dashboard Issues or PRs about Sentinel Dashboard labels Jan 10, 2024
@LearningGp
Copy link
Collaborator

The CLA needs to be signed before the code is merged. ✒️

@wangxiaof wangxiaof changed the title dashboard support resource regex dashboard support resource regex match Jan 11, 2024
@wangxiaof
Copy link
Author

The CLA needs to be signed before the code is merged. ✒️

done

LearningGp
LearningGp previously approved these changes Jan 11, 2024
Copy link
Collaborator

@LearningGp LearningGp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp
Copy link
Collaborator

The CLA needs to be signed before the code is merged. ✒️

done

It seems that the CLA was not signed successfully. You might need to add the email address used for this commit to your GitHub account.

@wangxiaof
Copy link
Author

The CLA needs to be signed before the code is merged. ✒️

done

It seems that the CLA was not signed successfully. You might need to add the email address used for this commit to your GitHub account.

@wangxiaof wangxiaof closed this Jan 12, 2024
@wangxiaof wangxiaof reopened this Jan 12, 2024
@wangxiaof
Copy link
Author

This workflow requires approval from a maintainer. Learn more about approving workflows.
我修改了我把commit的email修改的和github上一样的了,然后重新提交了部分代码,这次看看能不能通过

@wangxiaof wangxiaof closed this Jan 12, 2024
@wangxiaof wangxiaof reopened this Jan 12, 2024
@wangxiaof
Copy link
Author

close this pr and open new pr.

@wangxiaof wangxiaof closed this Jan 12, 2024
@wangxiaof wangxiaof deleted the feature/dashbord_resource_regex branch January 12, 2024 04:56
@wangxiaof
Copy link
Author

#3305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard to-review To review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants