Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/global config #2306

Closed

Conversation

JacksonZhang95
Copy link

Describe what this PR does / why we need it

support default rule extension

Does this pull request fix one issue?

[Feature] Support setting the universal default rule for all resources #66

Describe how you did it

  1. 抽取xxxRuleManager里面PropertyListener出来,由SPI进行加载做自定义化
  2. 抽象RuleSelector, 用于slot的规则选取

Describe how to verify it

junit test

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jiez95
❌ zhangjie


zhangjie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sczyh30
Copy link
Member

sczyh30 commented Jul 27, 2021

Hi, thanks for contributing. Could you please sign the CLA here? And please make sure the email of your commits match your GitHub email. You may refer to the instruction here, or rebase your commits with the correct email.


感谢贡献,请将 commit 对应的 email 调整成与 GitHub 的 email 相匹配并 确认一下 CLA

@sczyh30
Copy link
Member

sczyh30 commented Jul 27, 2021

You may also need to resolve the CI failure.

@JacksonZhang95 JacksonZhang95 deleted the feature/global_config branch July 27, 2021 01:59
@JacksonZhang95 JacksonZhang95 restored the feature/global_config branch July 27, 2021 02:00
@JacksonZhang95 JacksonZhang95 deleted the feature/global_config branch July 27, 2021 02:01
@JacksonZhang95 JacksonZhang95 restored the feature/global_config branch July 27, 2021 02:04
@JacksonZhang95 JacksonZhang95 deleted the feature/global_config branch July 27, 2021 12:59
@JacksonZhang95 JacksonZhang95 restored the feature/global_config branch July 27, 2021 13:06
@JacksonZhang95 JacksonZhang95 deleted the feature/global_config branch July 27, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants