An improved method for obtaining ip address and port number from cont… #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
added
area/configuration
sczyh30
reviewed
Apr 26, 2021
sentinel-core/src/main/java/com/alibaba/csp/sentinel/config/SentinelConfig.java
Outdated
Show resolved
Hide resolved
|
Good idea. Supporting config from system env is necessary for cloud-native services. The mechanism of |
|
Thanks for contributing and look forward to more! |
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
…Config (alibaba#2154) - An improved method for obtaining IP address and port number from containers
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 14, 2021
…Config (alibaba#2154) - An improved method for obtaining IP address and port number from containers
linkolen
pushed a commit
to shivagowda/Sentinel
that referenced
this pull request
Aug 16, 2021
…Config (alibaba#2154) - An improved method for obtaining IP address and port number from containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
如果用户代码docker化后,env的操作成本要比-D传进来的成本低很多.因此env是原生云环境下指定ip和端口的比较好的办法.
这样dashboard 推送rule信息修改就没有任何问题了