Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] modified sentinel-dubbo-adapter module DefaultDubboFallback… #1755

Closed
wants to merge 1 commit into from
Closed

Conversation

wzg923
Copy link
Contributor

@wzg923 wzg923 commented Sep 23, 2020

Describe what this PR does / why we need it

fixed the bug of sentinel-dubbo-adapter [Caused by: java.lang.RuntimeException: Serialized class com.alibaba.csp.sentinel.slots.block.flow.FlowRule must implement java.io.Serializable]

Does this pull request fix one issue?

fixed issue #1065

Describe how you did it

Just wrap the BlockException to a custom RuntimeException,so the result do not contains the BlockException.

Describe how to verify it

Verify it by run the example project of sentinel-demo-dubbo .

Special notes for reviews

….java class,resolve the issue #1065 [Serialized class com.alibaba.csp.sentinel.slots.block.flow.FlowRule must implement java.io.Serializable]
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wangzhenguang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sczyh30
Copy link
Member

sczyh30 commented Sep 23, 2020

Hi, thanks for contributing. Could you please sign the CLA here? And please make sure the email of your commits match your GitHub email. You may refer to the instruction here, or rebase your commits with the correct email.


感谢贡献,请将 commit 对应的 email 调整成与 GitHub 的 email 相匹配并 确认一下 CLA

@sczyh30
Copy link
Member

sczyh30 commented Sep 23, 2020

And could you please solve the CI failure?

@sczyh30 sczyh30 added area/integrations Issues or PRs related to integrations with open-source components kind/enhancement Category issues or prs related to enhancement. labels Sep 23, 2020
@wzg923
Copy link
Contributor Author

wzg923 commented Sep 23, 2020

close this PR,edit commit email info

@wzg923 wzg923 closed this Sep 23, 2020
@wzg923 wzg923 reopened this Sep 23, 2020
@wzg923 wzg923 closed this Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Issues or PRs related to integrations with open-source components kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants