-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Degrade by RT should consider inflight request #1405
Comments
Good suggestion. This could be helpful for sparse slow requests. We could discuss the detail of the strategy here :) |
Any thoughts? (maybe combine with concurrency control?) |
Could you give me more informations about it? |
IMHO, the PR #1490 seems did not fix this issue. The main point of problem is that ** Whether the Sentinel circuit breaker can cut off the traffic when it know inflight entries will trigger the breaker finally,instead of all unexpected slow entries exit ** At some implementations such as hystrix , another thread will perform some fallback work when a actual working thread does not return after a timeout. With the current structure of Sentinel, it is not suitable to achieve a similar implementations, but some designs can be used to achieve the same effect:
I will try to work on it, any other thoughts? ;-) |
…ing previous buckets when the entry tries to pass (alibaba#1405) Signed-off-by: Jerry.Zhong <15951609026@163.com>
Issue Description
Type: feature request
Describe what happened (or what feature you want)
Now degrading by RT only consider finished requests because rt stat is collected when exit, but it ingores inflight requests. I thinks it is not accurate:
When the count of inflight and overtime requests has exceeds threshold, but Sentinel will allow the below requests.
Describe what you expected to happen
Tell us your environment
Anything else we need to know?
The text was updated successfully, but these errors were encountered: