Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Fix bugs of check ready #4381

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

lnfjpt
Copy link
Collaborator

@lnfjpt lnfjpt commented Dec 20, 2024

Copy link
Contributor

github-actions bot commented Dec 26, 2024

Please check the preview of the documentation changes at
https://70b0f38d.graphscope-docs-preview.pages.dev

zhanglei1949
zhanglei1949 previously approved these changes Jan 2, 2025
Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.32%. Comparing base (f41a761) to head (2c1dc3f).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4381      +/-   ##
==========================================
- Coverage   34.33%   34.32%   -0.01%     
==========================================
  Files         126      126              
  Lines       13257    13260       +3     
==========================================
  Hits         4552     4552              
- Misses       8705     8708       +3     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f41a761...2c1dc3f. Read the comment docs.

BingqingLyu
BingqingLyu previously approved these changes Jan 3, 2025
@lnfjpt lnfjpt dismissed stale reviews from BingqingLyu and zhanglei1949 via 066ca80 January 7, 2025 03:03
@lnfjpt lnfjpt requested a review from longbinlai January 7, 2025 07:00
Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lnfjpt lnfjpt merged commit f8250fb into alibaba:main Jan 9, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants