Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove color function from flood fill because it is redundant #766

Merged
merged 3 commits into from
Oct 15, 2020

Conversation

leios
Copy link
Member

@leios leios commented Oct 13, 2020

Direct fix for #765

Because the color function is essentially a bounds check before coloring and the bounds check is done upon querying neighbors, it's not necessary to check on color as well.

I have removed the function and the text associated with it.

This might also change code in #752 and #743

@lazyprop
Copy link
Contributor

lazyprop commented Oct 14, 2020

This adds the unnecessary a.out binary.

Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that this works and the book output is correct, but the compiled a.out binary needs to be removed.

@berquist berquist added Hacktoberfest The label for all Hacktoberfest related things! Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) labels Oct 15, 2020
@leios
Copy link
Member Author

leios commented Oct 15, 2020

Woops. Removed the binary file. Thanks for the catch!

@berquist berquist merged commit fee7e83 into algorithm-archivists:master Oct 15, 2020
@leios leios deleted the flood_fill_fix branch October 15, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest The label for all Hacktoberfest related things! Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants