Thomas algorithm implementation in Common Lisp #604
Conversation
june128
added
the
Implementation
| (setf | ||
| (svref d i) | ||
| (/ | ||
| (- (svref d i) (* (svref a i) (svref d (1- i)))) |
There was a problem hiding this comment.
If you want to write a macro, (- (svref d i) (* (svref a i) (svref d (1- i)))) is probably the level of granularity that you want, with a separate macro for the 1+ version. Since you aren't shortening the code by using macros, make sure you use a descriptive macro name.
| (defun thomas (a b c d) | ||
| "Returns the solutions to a tri-diagonal matrix destructively" | ||
| (setf (svref c 0) (/ (svref c 0) (svref b 0))) | ||
| (setf (svref d 0) (/ (svref d 0) (svref b 0))) |
There was a problem hiding this comment.
Same comment about the macro here. Give them good docstrings.
|
Poke for rebase. I think the only thing I care about from the review is printing in floating point. |
|
I'm almost done, I found that (helper b a c i) is used twice so I might make that a separate variable in the loop. I also need an explanation for what the helper function actually does. I discovered that I didn't need macros and that functions could do the job. |
While I probably could've done some funky recursion with this. I'm keeping it simple for this first submission. The
svrefand thesetfsyntax is wordy and annoying so I might make a specific function or even a macro for that. The function is destructive so I either have to find a copy command for a vector or re-write the entire function.It'd be great to first have a review though.