euclid algorithm in scheme #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
the
Implementation
Trashtalk217
requested changes
Feb 2, 2019
|
I am pretty sure I fixed everything. I changed the (cond)s to (if)s, it makes it cleaner and a bit more consistent with the Common Lisp implementations. |
berquist
approved these changes
Feb 2, 2019
| @@ -0,0 +1,16 @@ | |||
| (define (euclid-sub a b) | |||
| (if (or (negative? a) (negative? b)) | |||
There was a problem hiding this comment.
The line under each of the two defines is the only one that shouldn't be aligned with the above subexpression: http://community.schemewiki.org/?scheme-style
Trashtalk217
requested changes
Feb 2, 2019
| (cond | ||
| [(or (negative? a) (negative? b)) (euclid-sub (abs a) (abs b))] | ||
| [(eq? a b) a] | ||
| (if (> a b) |
There was a problem hiding this comment.
this could be part of the first cond:
[(eq? a b) a]
[(> a b) (euclid-sub (- a b) b)]
[else (euclid-sub a (- b a)]
There was a problem hiding this comment.
oh yeah that was my bad I meant to put that in the cond statement
|
There is extra whitespace in the first few lines of the cond. The |
Trashtalk217
approved these changes
Feb 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented euclidean GCD algorithm in scheme. Added scheme to book.json. Tested with ChezScheme 9.5 and ChickenScheme 4.12.