Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding FFT in X86_64 #542

Merged
merged 4 commits into from
Dec 31, 2018
Merged

Adding FFT in X86_64 #542

merged 4 commits into from
Dec 31, 2018

Conversation

Gathros
Copy link
Contributor

@Gathros Gathros commented Nov 5, 2018

No description provided.

@Gathros Gathros added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label Nov 5, 2018
Liikt
Liikt requested changes Nov 17, 2018
View reviewed changes
Copy link

@Liikt Liikt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first small thing I found. There may be more to come in the near future.

contents/cooley_tukey/code/asm-x64/fft.s Show resolved Hide resolved
Liikt
Liikt requested changes Dec 24, 2018
View reviewed changes
Copy link

@Liikt Liikt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally got around to looking at your PR. Sorry it took so long.

contents/cooley_tukey/code/asm-x64/fft.s Outdated Show resolved Hide resolved
contents/cooley_tukey/code/asm-x64/fft.s Outdated Show resolved Hide resolved
contents/cooley_tukey/code/asm-x64/fft.s Outdated Show resolved Hide resolved
contents/cooley_tukey/code/asm-x64/fft.s Outdated Show resolved Hide resolved
contents/cooley_tukey/code/asm-x64/fft.s Outdated Show resolved Hide resolved
contents/cooley_tukey/code/asm-x64/fft.s Show resolved Hide resolved
@Liikt Liikt mentioned this pull request Dec 24, 2018
Open
@Liikt
Copy link

Liikt commented Dec 24, 2018

Also we should consider the problem described in #558. I know it's a bit harder and very verbose to do in asm, but maybe we can come up with a good solution

@Liikt
Copy link

Liikt commented Dec 24, 2018

This looks good now. Maybe @Gustorn wants to take a look as well? If not we can merge this.

@Gathros Gathros merged commit 1048a07 into algorithm-archivists:master Dec 31, 2018
@Gathros Gathros deleted the fft_x64 branch December 31, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liikt Liikt Liikt approved these changes

Assignees
No one assigned
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gathros @Liikt