fix: prevent assertion error when using dynamic key with storage prox…

…y and assinging to self member

src/puya/awst_build/contract_data.py

@@ -37,7 +37,6 @@ def key(self) -> BytesConstant:
             case invalid_kind:
                 typing.assert_never(invalid_kind)
         if self.key_override is not None:
-            assert self.key_override.wtype == wtype
             bytes_const = self.key_override
         else:
             bytes_const = BytesConstant(

src/puya/awst_build/eb/storage/_util.py

@@ -185,7 +185,8 @@ def build_definition(
         key_override = self.resolve()
         if not isinstance(key_override, BytesConstant):
             logger.error(
-                f"assigning {typ} to a member variable requires a constant value for key",
+                f"assigning {typ} to a member variable requires a constant value for"
+                f" key{'_prefix' if isinstance(typ, pytypes.StorageMapProxyType) else ''}",
                 location=location,
             )
             key_override = BytesConstant(

tests/test_expected_output/box.test

@@ -186,3 +186,14 @@ class MyContract(arc4.ARC4Contract):
     def __init__(self) -> None:
         self.my_box = Box(bool, key="")
         assert not self.my_box.length, "length op fails because the key is empty"  ## E: AVM does not support empty box keys
+
+
+## case: dynamic_keys_with_self_assignment
+from algopy import *
+
+class MyContract(arc4.ARC4Contract):
+    def __init__(self) -> None:
+        dynamic = String("dynamic")
+        self.box = Box(UInt64, key=dynamic) ## E: assigning algopy.Box[algopy.UInt64] to a member variable requires a constant value for key
+        self.box_map = BoxMap(UInt64, UInt64, key_prefix=dynamic) ## E: assigning algopy.BoxMap[algopy.UInt64, algopy.UInt64] to a member variable requires a constant value for key_prefix
+        self.box_ref = BoxRef(key=dynamic) ## E: assigning algopy.BoxRef to a member variable requires a constant value for key

tests/test_expected_output/global_proxy.test

@@ -41,6 +41,16 @@ class StateProxyContract4(ARC4Contract):
 
 
 class StateProxyContract5(ARC4Contract):
+    def __init__(self) -> None:
+        dynamic = String("dynamic")
+        self._global = GlobalState(UInt64, key=dynamic) ## E: assigning algopy.GlobalState[algopy.UInt64] to a member variable requires a constant value for key
+        self.local_ = LocalState(UInt64, key=dynamic) ## E: assigning algopy.LocalState[algopy.UInt64] to a member variable requires a constant value for key
+
+
+## case: test_global_stubs
+from algopy import *
+
+class StateProxyContract6(ARC4Contract):
     def __init__(self) -> None:
         self.global_ = GlobalState(UInt64(0), key=String("global3")) ## E: No overload variant of "GlobalState" matches argument types "UInt64", "String"  [call-overload] \
                                                                      ## N: def [_TState] __init__(self, _TState, /, *, key: bytes | str = ..., description: str = ...) -> GlobalState[_TState] \