bug-fix: better configuration of plugin loggers + trace all algod requests #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 67.66% 69.31% +1.65%
==========================================
Files 32 36 +4
Lines 1976 2428 +452
==========================================
+ Hits 1337 1683 +346
- Misses 570 653 +83
- Partials 69 92 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
changed the title
tzaffi
commented
Jun 4, 2023
tzaffi
commented
Jun 4, 2023
| lgr := log.New() | ||
| lgr.SetOutput(p.logger.Out) | ||
| lgr.SetLevel(p.logger.Level) | ||
| lgr.SetFormatter(makePluginLogFormatter(string(pluginType), cfg.Name)) |
There was a problem hiding this comment.
Previously, all plugin loggers were assigned "processor" as their source.
tzaffi
commented
Jun 4, 2023
| l.SetFormatter(makePluginLogFormatter(plugins.Processor, cfg.Name)) | ||
| lgr := log.New() | ||
| lgr.SetOutput(p.logger.Out) | ||
| lgr.SetLevel(p.logger.Level) |
There was a problem hiding this comment.
Inheriting the log level from the pipeline
shiqizng
approved these changes
Jun 5, 2023
winder
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In preparing the bugfix in algorand/go-algorand#5449, I discovered that conduit's logger wasn't printing out at the log-level that I was expecting (TRACE). I made some minor fixes to address this problem and also added the traces that I found helpful. Finally, a couple of logs were missing the received error from algod, so I added these.
Test Plan
CI + local testing