init: Option to write config file to stdout. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 66.23% 66.23%
=======================================
Files 33 33
Lines 1869 1869
=======================================
Hits 1238 1238
Misses 566 566
Partials 65 65 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algochoi
approved these changes
Mar 30, 2023
shiqizng
approved these changes
Mar 30, 2023
| fmt.Printf("\nOnce the config file is updated, start Conduit with:\n") | ||
| fmt.Printf(" ./conduit -d %s\n", path) | ||
| // If a data dir is created, print some additional help. | ||
| if path != "" { |
There was a problem hiding this comment.
nit: it may be better to use configWriter==nil check here; one fewer var to track. path is getting updated at line 58 and it only happens when configWriter == nil.
There was a problem hiding this comment.
configWriter is set to the file on line 74. I agree that the logic is strange, maybe I should just refactor to avoid the strange logic.
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
shiqizng
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While creating a docker container, I found that it could be used like
docker run algorand/conduit initto create a config file. The problem is that output is written to a file.This changes the behavior of
conduit init. Previously it would create a directory nameddatacontaining the config file, now it writes the config file to stdout. To get the previous behavior you would use the commandconduit init -d data.Test Plan
Unit tests are updated to cover the new behavior.