Automation things: codecov, linting, github. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=========================================
Coverage ? 66.64%
=========================================
Files ? 32
Lines ? 1805
Branches ? 0
=========================================
Hits ? 1203
Misses ? 535
Partials ? 67 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
requested review from
algo-dev-service,
Eric-Warehime and
shiqizng
and removed request for
algo-dev-service
bbroder-algo
reviewed
Mar 9, 2023
shiqizng
reviewed
Mar 9, 2023
| GOLDFLAGS += -X github.com/algorand/indexer/version.Dirty=$(if $(filter $(strip $(shell git status --porcelain|wc -c)), "0"),,true) | ||
| GOLDFLAGS += -X github.com/algorand/indexer/version.CompileTime=$(shell date -u +%Y-%m-%dT%H:%M:%S%z) | ||
| GOLDFLAGS += -X github.com/algorand/indexer/version.GitDecorateBase64=$(shell git log -n 1 --pretty="%D"|base64|tr -d ' \n') | ||
| #GOLDFLAGS += -X github.com/algorand/indexer/version.ReleaseVersion=$(shell cat .version) |
There was a problem hiding this comment.
why is this commented out?
There was a problem hiding this comment.
The .version file has always been a bit hacky. I'll look into using goreleaser and git tags to replace it.
|
|
||
| test: | ||
| go test -coverpkg=$(COVERPKG) ./... -coverprofile=coverage.txt -covermode=atomic ${TEST_FLAG} | ||
|
|
There was a problem hiding this comment.
are we adding the e2e test later?
There was a problem hiding this comment.
Yes, I'd like to add them in a separate PR since this one is already pretty big.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate automation from Indexer repo: