-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: Goreleaser configuration and automation. #18
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 67.23% 67.53% +0.30%
==========================================
Files 32 33 +1
Lines 1819 1833 +14
==========================================
+ Hits 1223 1238 +15
- Misses 529 530 +1
+ Partials 67 65 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not familiar with how the versioning bits work in Indexer so someone else should chime in on missing functionality.
I guess functionally, when comparing this release (created directly from github actions) and the indexer releases, we'll lose the signed binaries and the deb packages. However, you do include the checksums, so it depends on if this is enough. This is not my strongest area, so I am just quoting from this post:
One other thing we do that hasn't been automated is updating the release page as well: http://releases.algorand.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a useful utility, so I'm looking forward to trying in in our release process. I'm sure we'll want to make later additions. It should be useful bit of tooling towards reproducible builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and same sentiment as @excalq
Summary
Enable goreleaser for building and publishing conduit binaries.
The automation triggers whenever a tag starting with
v1.
is pushed.The previous versioning and deployment stuff seemed really complicated, and I'm really not sure what it was adding. Please let me know if this smaller process is missing any important functionality that needs to be added back.
Test Plan
I pushed a tag to my fork:
The downloaded binary looks good: