Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Goreleaser configuration and automation. #18

Merged
merged 7 commits into from
Mar 21, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Mar 16, 2023

Summary

Enable goreleaser for building and publishing conduit binaries.

The automation triggers whenever a tag starting with v1. is pushed.

The previous versioning and deployment stuff seemed really complicated, and I'm really not sure what it was adding. Please let me know if this smaller process is missing any important functionality that needs to be added back.

Test Plan

I pushed a tag to my fork:

The downloaded binary looks good:

$ ./conduit -v
Conduit 1.0.0 (c8262a5)

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #18 (f7f633d) into master (9c7f525) will increase coverage by 0.30%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   67.23%   67.53%   +0.30%     
==========================================
  Files          32       33       +1     
  Lines        1819     1833      +14     
==========================================
+ Hits         1223     1238      +15     
- Misses        529      530       +1     
+ Partials       67       65       -2     
Impacted Files Coverage Δ
version/strings.go 40.00% <40.00%> (ø)
conduit/plugins/importers/algod/algod_importer.go 83.70% <100.00%> (+5.84%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder changed the title goreleaser: Release configuration and automation. release: Goreleaser configuration and automation. Mar 16, 2023
Copy link
Contributor

@Eric-Warehime Eric-Warehime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not familiar with how the versioning bits work in Indexer so someone else should chime in on missing functionality.

@algobarb
Copy link

I guess functionally, when comparing this release (created directly from github actions) and the indexer releases, we'll lose the signed binaries and the deb packages. However, you do include the checksums, so it depends on if this is enough.

This is not my strongest area, so I am just quoting from this post:

Checksums ensure data integrity.
Digital signatures additionally ensure data authenticity.

One other thing we do that hasn't been automated is updating the release page as well: http://releases.algorand.com/

Copy link

@excalq excalq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a useful utility, so I'm looking forward to trying in in our release process. I'm sure we'll want to make later additions. It should be useful bit of tooling towards reproducible builds.

Copy link

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and same sentiment as @excalq

@winder winder merged commit c15d7ab into algorand:master Mar 21, 2023
@winder winder deleted the will/build branch March 21, 2023 20:50
tzaffi pushed a commit to tzaffi/conduit that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants