Allow catchpoints from the exact target round #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually tested this change with a follower node and fast catchup, and I can confirm it worked as expected |
gmalouf
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
algorand/go-algorand#5352 has been fixed by algorand/go-algorand#5798, and this PR undoes the workaround needed because of the original issue.
The original issue was that, if algod does fast catchup to round
X, algod's REST API could not serve blockX, since fast catchup did not also include block certificates. To work around this, conduit had to limit catchpoints to rounds< X, but now with this fixed in algod, the catchpoint round can be<= X.Test Plan
New unit test cases added