This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(ais-dynamic-widgets): add implementation #922
feat(ais-dynamic-widgets): add implementation #922
Changes from 3 commits
895435a
1623dde
e889c24
1eac466
d9779b5
2002f4b
b5de4de
fae4a19
9d3c481
1b8a9d7
3df3e84
650b956
966a8bf
c0d1823
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this behavior result in an unexpected UI flash were some widget will appear and then get removed because computed based on
state.attributesToRender
?What if we don't render anything when we don't have a state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that the widgets we render initially are hidden, so this won't cause a flash, but possibly slightly delayed visuals compared to server side rendering (which solves this, as the widget information is available on that server + initial frontend render)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I think I rather meant: won't this results in an unnecessary search parameters computation because it mounts widgets that will likely get removed?
Why don't we render nothing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we render nothing, the parameters of the URL can't be applied unfortunately, this was the best workaround I found