This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(widget:toggle-refinement): allow multiple values for "on" and "off" #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, can't wait to use it :) |
|
Thanks for the PR, the |
|
Hi @Kocal, could you rebase this on the |
|
Ah great, v3 has been released! EDIT: PR rebased |
Kocal
force-pushed
the
feat/widget-toggle-refinement-multiple-values
branch
from
03b4b6b to
423b284
Compare
Haroenv
reviewed
Jun 17, 2020
Co-authored-by: Haroen Viaene <fingebimus@me.com>
Haroenv
approved these changes
Jun 18, 2020
|
No problem :) |
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…algolia/vue-instantsearch#780) * feat(widget:toggle-refinement): allow multiples values for "on" and "off" * chore: add story * Update stories/ToggleRefinement.stories.js Co-authored-by: Haroen Viaene <fingebimus@me.com> Co-authored-by: Haroen Viaene <fingebimus@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
This PR is for the proposal algolia/instantsearch#4420, which allow multiple values for
onandoffprops.Thanks!