This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 157
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(nuxt3): forward $nuxt on the instance by default (#1112)
* fix(nuxt3): forward $nuxt on the instance by default This is similar to how we forward $router and $store, but in this case it needs to happen before the beforeCreate of nuxt happens * conditionnel présent
- Loading branch information
Showing
2 changed files
with
62 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acda293
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're seeing fatal errors during SSR since
vue-instantsearch@4.3.3
with Nuxt 2.15.8. Rolling back to 4.3.2 fixes the issue.acda293
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your report @weotch, can you reproduce this in a standalone GitHub repository? If you can, I'd love if you could create an issue to look into. Thanks a lot!
acda293
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to make a PR @weotch, but I can't yet reproduce, do you mind commenting on #1117, maybe trying out with the instructions on https://ci.codesandbox.io/status/algolia/vue-instantsearch/pr/1117/builds/223195?