-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do waitTask on all tasks before moving index #362
Conversation
@chloelbn have you seen this error in the CI before? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks great, for the CI errors, if I understand this change right: symfony/symfony#40986 then getOption will now sometimes return null, could this be why there are these errors in the CI?
@matthewbond You're right, fixed this in c2df2d4. I was referring to the following error however:
It looks like this comes from the fact that v3.4 of Symfony is no longer supported. I've dropped support for the older version of Symfony in d618f45. |
This issue mentions a fix: requiring the |
@matthewbond should be good now 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe your change
This updates the
SearchImport
command to wait until all indexing operations are done before performing amoveIndex
operation. This could prevent accidental loss of data.