Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import for aggregated models #350

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

ottaviano
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fix #337
Need Doc update no

Describe your change

This PR fix the import command which actually skips aggregated entities (Aggregator model).

@chloelbn
Copy link
Contributor

Hey @ottaviano !

Thanks a lot for your contribution. Would you mind adding some tests to your PR please?

@ottaviano
Copy link
Contributor Author

Hi @chloelbn, sure, but it seems that the tests depend on real Algolia backend? How can I run the test on local without real ALGOLIA_APP_ID and ALGOLIA_API_KEY?

@ottaviano
Copy link
Contributor Author

@chloelbn, is there a way to run the tests on local without a real Algolia API keys?

@chloelbn
Copy link
Contributor

chloelbn commented Dec 2, 2020

Hi @ottaviano, you can chose to run only the tests you created and not the whole test suite, so it won't eat up your units in your account. It's not ideal but shouldn't be an extreme rise in your operations. If you don't have an Algolia account, you can create a free one with a small dataset here. Don't hesitate to ping me again if it's not clear!

@wlasnapl
Copy link

Do you know when this will be merged and released?

@keichinger
Copy link

@chloelbn we're running into the same issue/bug. How can we help getting this PR merged and released?

@chloelbn
Copy link
Contributor

Hi @keichinger, thanks for your offer to help! You can write tests to make this move forward :)

@ottaviano ottaviano force-pushed the search-import-aggregated-models branch from 9c8ce5f to 07b3595 Compare January 14, 2021 18:07
@ottaviano ottaviano force-pushed the search-import-aggregated-models branch from 07b3595 to 9711254 Compare January 14, 2021 18:08
@ottaviano
Copy link
Contributor Author

Hi @keichinger, sorry for the wait :(

@chloelbn, I saw that there is already a test for the command search:index and I improve it to really test the case of aggregation.
Could you review, please?

@keichinger
Copy link

@ottaviano no worries! Anyone could have helped you out of there :) Especially during the holidays.

I'm glad that you've found the time to finish up this PR ☺️ I was planning on having a closer look at this PR tomorrow in the morning :) Guess that's no longer needed.

@chloelbn chloelbn merged commit 3968aa5 into algolia:master Jan 18, 2021
@ottaviano ottaviano deleted the search-import-aggregated-models branch January 18, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with aggregators in 4.1.0 version
4 participants