-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix import for aggregated models #350
Fix import for aggregated models #350
Conversation
Hey @ottaviano ! Thanks a lot for your contribution. Would you mind adding some tests to your PR please? |
Hi @chloelbn, sure, but it seems that the tests depend on real Algolia backend? How can I run the test on local without real |
@chloelbn, is there a way to run the tests on local without a real Algolia API keys? |
Hi @ottaviano, you can chose to run only the tests you created and not the whole test suite, so it won't eat up your units in your account. It's not ideal but shouldn't be an extreme rise in your operations. If you don't have an Algolia account, you can create a free one with a small dataset here. Don't hesitate to ping me again if it's not clear! |
Do you know when this will be merged and released? |
@chloelbn we're running into the same issue/bug. How can we help getting this PR merged and released? |
Hi @keichinger, thanks for your offer to help! You can write tests to make this move forward :) |
9c8ce5f
to
07b3595
Compare
07b3595
to
9711254
Compare
Hi @keichinger, sorry for the wait :( @chloelbn, I saw that there is already a test for the command |
@ottaviano no worries! Anyone could have helped you out of there :) Especially during the holidays. I'm glad that you've found the time to finish up this PR |
Describe your change
This PR fix the import command which actually skips aggregated entities (Aggregator model).