Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rendering): Expose createElement #85

Merged
merged 25 commits into from
Jun 21, 2022

Conversation

SophieManley03
Copy link
Contributor

This PR exposes createElement and Fragment from Preact.

Summary

We want to remove the complexity of using JSX for our users using plain Javascript. In order to do that in a unify way accross our librairies, we are doing a similar work to the one done on Autocomplete.js.

This PR will be followed by another one that we allow HTML templating.

@SophieManley03 SophieManley03 force-pushed the feat/recommend-templating-create-element branch 2 times, most recently from 3f8ded1 to 7022f3c Compare June 13, 2022 08:21
@SophieManley03 SophieManley03 force-pushed the feat/recommend-templating-create-element branch from 7022f3c to bcfa781 Compare June 13, 2022 08:26
SophieManley03 and others added 3 commits June 13, 2022 11:59
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
@sarahdayan
Copy link
Member

@SophieManley03 For the two suggestions I made you'll need to add imports from Renderer (that's why the type checking is failing). Unfortunately GitHub wouldn't let me suggest at the top of the file 😔

@SophieManley03
Copy link
Contributor Author

Thank you Sarah, just did 👌

@SophieManley03 SophieManley03 marked this pull request as ready for review June 13, 2022 13:23
@SophieManley03 SophieManley03 force-pushed the feat/recommend-templating-create-element branch from a5e1442 to 11cf12e Compare June 14, 2022 13:24
Copy link
Member

@sarahdayan sarahdayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nitpicks (feel free to apply or not), other than that it looks good to me. Great job!

SophieManley03 and others added 2 commits June 21, 2022 08:38
…est.tsx

Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
…est.tsx

Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
SophieManley03 and others added 11 commits June 21, 2022 08:38
…est.tsx

Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
…est.tsx

Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
…est.tsx

Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
@SophieManley03 SophieManley03 merged commit ea6e668 into next Jun 21, 2022
@SophieManley03 SophieManley03 deleted the feat/recommend-templating-create-element branch June 21, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants