feat(routing): replace getLocation with getCurrentURL #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getCurrentURL is the alternative of getLocation in the history router. This is changed as it's possible to create a URL out of a string, but not a location. We also don't use any properties of the location that aren't also present in a URL. [FX-3191] BREAKING CHANGE: change from `getLocation` to `getCurrentURL`, and return a URL object. BREAKING CHANGE: createURL createURL now receives `currentURL` instead of `location` BREAKING CHANGE: parseURL createURL now receives `currentURL` instead of `location`
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0b6ac5a:
|
dhayab
reviewed
Dec 19, 2024
|
I believe this also makes the ecom routing example possible to be simpler but I didn't want to untangle it in this pr yet |
Haroenv
added a commit
that referenced
this pull request
Dec 26, 2024
getCurrentURL is the alternative of getLocation in the history router. This is changed as it's possible to create a URL out of a string, but not a location. We also don't use any properties of the location that aren't also present in a URL. [FX-3191] BREAKING CHANGE: change from `getLocation` to `getCurrentURL`, and return a URL object. BREAKING CHANGE: createURL createURL now receives `currentURL` instead of `location` BREAKING CHANGE: parseURL createURL now receives `currentURL` instead of `location`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getCurrentURL is the alternative of getLocation in the history router. This is changed as it's possible to create a URL out of a string, but not a location. We also don't use any properties of the location that aren't also present in a URL.
FX-3193
BREAKING CHANGE: change from
getLocationtogetCurrentURL, and return a URL object.BREAKING CHANGE: createURL createURL now receives
currentURLinstead oflocationBREAKING CHANGE: parseURL createURL now receives
currentURLinstead oflocation