-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-instantsearch-app): support Autocomplete in InstantSearch.js template #5857
Conversation
2f33f54
to
2ea6262
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d084642:
|
packages/create-instantsearch-app/src/templates/InstantSearch.js/.template.js
Outdated
Show resolved
Hide resolved
packages/create-instantsearch-app/src/cli/postProcessAnswers.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me! I've just noticed we could do some changes on an upcoming PR to the JS template:
- choose to either keep CDN scripts or package dependencies (but not both)
- replace all
instantsearch.widgets.xxx
calls with their shortened versions (as documented)
packages/create-instantsearch-app/src/templates/InstantSearch.js/src/app.js.hbs
Outdated
Show resolved
Hide resolved
@dhayab I believe the npm dependencies are necessary to provide types in For the shortened versions, we can do this in another PR that updates all templates, wdyt? |
…js/src/app.js.hbs Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Summary
This introduces Autocomplete support in the InstantSearch.js template:
setIndexUiState
, CISA asks whether or not you want to use an autocomplete as a search box.When using an autocomplete as a search box, you get an autocomplete with recent searches and suggested searches. For the sake of code simplicity, routing isn't enabled, state is in memory.
Demo
FX-2618