fix(connectToggleRefinement): fix onFacetValue/offFacetValue on render when using arrays for on/off #4449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ender when using arrays for on/off
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f570974:
|
Haroenv
reviewed
Jul 20, 2020
src/connectors/toggle-refinement/__tests__/connectToggleRefinement-test.js
Show resolved
Hide resolved
|
nice catch ! |
Haroenv
approved these changes
Jul 22, 2020
eunjae-lee
changed the title
eunjae-lee
approved these changes
Jul 22, 2020
|
CircleCI didn't run. I ran the tests and they all passed on my computer, so I'm merging it. |
|
Thanks! Is there a reason for CircleCI not running? It's not the first time I see this. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was working on #4445 and I found a bug introduced by myself in #4420. 😐
The bug is in
rendermethod, whereonFacetValueandoffFacetValuecould be wrong when using arrays foronoroff.I've added a failing test:
Result
rendermethod now handleonFacetValueandoffFacetValuecorrectly when using arrays foronandoffoptions.Thanks!