feat(searchbox): add aria-label

[Haroenv]

See: https://github.com/algolia/react-instantsearch/issues/2863 (doesn't fix this fully, but it's a start)

[francoischalifour]

See algolia/instantsearch#4271 (review).

[Haroenv]

That makes sense @francoischalifour, I'll add aria. Note that in this spec we mix translations and other props, since it's only React InstantSearch so far which has them

[sarahdayan]

@Haroenv In React InstantSearch Hooks we started adding translations for aria-* (see <Pagination>)—we could add similar translations for <SearchBox>.

In InstantSearch.js we support translations with the Templates API, so we could introduce new templates for it.

Should we merge it, then reflect it later in our libraries?

[Haroenv]

Yes, that would be doable. I think I'd be more comfortable merging when we're ready to implement the change though

[sarahdayan]

That's fair, and will probably be easier to enforce once all code lives together.

I'll leave this open so I can have a list of PRs to reopen once the migration is effective. Since this is a breaking change I'll make this an issue to avoid long-lived PRs that get out of date and require more work than necessary.

[sarahdayan]

Referred this PR in algolia/instantsearch#5188, closing it here before archiving.