Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project name #1

Closed
mjackson opened this issue Oct 16, 2015 · 3 comments
Closed

Project name #1

mjackson opened this issue Oct 16, 2015 · 3 comments
Assignees
@vvo
Labels
enhancement

Comments

@mjackson
Copy link

Would you be open to renaming the project from expect-to-equal-jsx to simply expect-jsx? I think the name is a bit stronger, and would help people understand better what it's for.
@vvo
Copy link
Contributor

vvo commented Oct 16, 2015

Ah yes good, will do.

What about the underlying react-element-to-jsx-string, have a better name or we are good?

@vvo
Copy link
Contributor

vvo commented Oct 16, 2015

Also, would we keep toEqualJSX? I believe yes.

@vvo vvo self-assigned this Oct 16, 2015
@vvo
Copy link
Contributor

vvo commented Oct 16, 2015

Ok moved to #3

@vvo vvo closed this as completed Oct 16, 2015
vvo pushed a commit that referenced this issue Oct 19, 2015
fix: change package name to expect-jsx
665ed66 
fixes #3
ref #1

BREAKING CHANGE: package is now installed with `npm install expect-jsx
--save-dev`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvo vvo

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjackson @vvo