fix(concurrency): ensure panel stays closed after blur (patch) #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3963667:
|
sarahdayan
reviewed
Dec 3, 2021
Comment on lines
46
to
48
| nextStateRef = nextState; | ||
| propsRef = props; | ||
| queryRef = query; |
There was a problem hiding this comment.
Why delete those? When you're not in a shouldSkipSearch situation, you'd need those because you're not guaranteed to have the last called onInput resolve last.
There was a problem hiding this comment.
I relied on the tests for the implementation and this doesn't seem to be covered then. We can add it back and test it.
There was a problem hiding this comment.
Yes let's test it in the base PR.
sarahdayan
force-pushed
the
fix/late-promises-on-submit-skipSearch-patch
branch
from
8311351
to
3963667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed patch on top of #829.
See #829 (review).
I did it very quickly so we can rename things later.