Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(classic-theme): fix modal display in desktop Detached Mode #531

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

sarahdayan
Copy link
Member

We had a bug preventing the panel to display at all in desktop Detached Mode. This PR fixes it.

Next steps

We should have a dedicated demo for desktop Detached Mode, along with visual regression tests to avoid breaking the UI without us knowing.

@codesandbox-ci
Copy link

@Shipow
Copy link
Contributor

Shipow commented Apr 14, 2021

thanks for fixing it!

Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sarahdayan sarahdayan merged commit abf98ef into next Apr 15, 2021
@sarahdayan sarahdayan deleted the fix/detached-mode-modal branch April 15, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants