-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autocomplete-js): query
is reflected in the detached search button
#1100
Conversation
query
is reflected in the detached search button
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6d07470:
|
query
is reflected in the detached search buttonquery
is reflected in the detached search button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great to me, works as expected, and like the solution, even for long queries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elegant solution! I left a few non blocking comments, feel free to address or not and merge 👍
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Summary
Currently in
autocomplete-js
using the detached mode:query
is reset.query
.Result
query
is persisted in a newdiv
with the class.aa-DetachedSearchButtonQuery
.query
is not empty, the placeholder.aa-DetachedSearchButtonPlaceholder
is hidden.→ CodeSandbox
Fixes #636 and #1010