Skip to content

Commit

Permalink
feat(core): pass scoped API to lifecycle hooks
Browse files Browse the repository at this point in the history
  • Loading branch information
@francoischalifour
francoischalifour committed Feb 1, 2021
1 parent 00455d0 commit 542d72b
Show file tree
Hide file tree
Showing 20 changed files with 586 additions and 462 deletions.
78 changes: 42 additions & 36 deletions packages/autocomplete-core/src/__tests__/completion.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,30 +26,33 @@ describe('completion', () => {
inputElement.focus();
userEvent.type(inputElement, '{arrowdown}');

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
completion: '1',
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
completion: '1',
}),
})
);

userEvent.type(inputElement, '{arrowdown}');

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
completion: '2',
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
completion: '2',
}),
})
);

userEvent.type(inputElement, '{arrowdown}');

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
completion: null,
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
completion: null,
}),
})
);
});

test('does not set completion when panel is closed', () => {
Expand All @@ -74,12 +77,13 @@ describe('completion', () => {
inputElement.focus();
userEvent.type(inputElement, '{esc}{arrowdown}');

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
completion: null,
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
completion: null,
}),
})
);
});

test('does not set completion when no activeItemId', () => {
Expand All @@ -92,12 +96,13 @@ describe('completion', () => {
inputElement.focus();
userEvent.type(inputElement, '{arrowdown}');

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
completion: null,
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
completion: null,
}),
})
);
});

test('does not set completion without itemInputValue', () => {
Expand All @@ -117,11 +122,12 @@ describe('completion', () => {
inputElement.focus();
userEvent.type(inputElement, '{arrowdown}');

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
completion: null,
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
completion: null,
}),
})
);
});
});
15 changes: 8 additions & 7 deletions packages/autocomplete-core/src/__tests__/createAutocomplete.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,19 @@ describe('createAutocomplete', () => {

test('subscribes all plugins', () => {
const plugin = { subscribe: jest.fn() };
createAutocomplete({ plugins: [plugin] });
const autocomplete = createAutocomplete({ plugins: [plugin] });

expect(plugin.subscribe).toHaveBeenCalledTimes(1);
expect(plugin.subscribe).toHaveBeenLastCalledWith({
onActive: expect.any(Function),
onSelect: expect.any(Function),
setCollections: expect.any(Function),
setContext: expect.any(Function),
setIsOpen: expect.any(Function),
setQuery: expect.any(Function),
setActiveItemId: expect.any(Function),
setStatus: expect.any(Function),
refresh: autocomplete.refresh,
setCollections: autocomplete.setCollections,
setContext: autocomplete.setContext,
setIsOpen: autocomplete.setIsOpen,
setQuery: autocomplete.setQuery,
setActiveItemId: autocomplete.setActiveItemId,
setStatus: autocomplete.setStatus,
});
});
});
9 changes: 5 additions & 4 deletions packages/autocomplete-core/src/__tests__/debug.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ describe('debug', () => {
inputElement.focus();
inputElement.blur();

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({ isOpen: true }),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({ isOpen: true }),
})
);
});
});
78 changes: 42 additions & 36 deletions packages/autocomplete-core/src/__tests__/defaultSelectedItemId.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,13 @@ describe('defaultActiveItemId', () => {

userEvent.type(inputElement, 'a');

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
activeItemId: null,
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
activeItemId: null,
}),
})
);
});

test('selects provided defaultActiveItemId on open (onInput)', () => {
Expand All @@ -39,12 +40,13 @@ describe('defaultActiveItemId', () => {

inputElement.focus();

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
activeItemId: 0,
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
activeItemId: 0,
}),
})
);
});

test('selects defaultActiveItemId with openOnFocus on reset', () => {
Expand All @@ -66,12 +68,13 @@ describe('defaultActiveItemId', () => {
autocomplete.setActiveItemId(null);
formElement.reset();

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
activeItemId: 0,
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
activeItemId: 0,
}),
})
);
});

test('selects defaultActiveItemId on focus', () => {
Expand All @@ -88,12 +91,13 @@ describe('defaultActiveItemId', () => {

inputElement.focus();

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
activeItemId: 0,
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
activeItemId: 0,
}),
})
);
});

test('selects defaultActiveItemId when ArrowDown on the last', () => {
Expand All @@ -114,12 +118,13 @@ describe('defaultActiveItemId', () => {

userEvent.type(inputElement, '{arrowdown}');

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
activeItemId: 0,
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
activeItemId: 0,
}),
})
);
});

test('selects defaultActiveItemId when ArrowUp on the first', () => {
Expand All @@ -140,11 +145,12 @@ describe('defaultActiveItemId', () => {

userEvent.type(inputElement, '{arrowup}');

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
activeItemId: 0,
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
activeItemId: 0,
}),
})
);
});
});
15 changes: 8 additions & 7 deletions packages/autocomplete-core/src/__tests__/getEnvironmentProps.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,14 @@ describe('getEnvironmentProps', () => {
});
window.document.dispatchEvent(customEvent);

expect(onStateChange).toHaveBeenLastCalledWith({
prevState: expect.anything(),
state: expect.objectContaining({
activeItemId: null,
isOpen: false,
}),
});
expect(onStateChange).toHaveBeenLastCalledWith(
expect.objectContaining({
state: expect.objectContaining({
activeItemId: null,
isOpen: false,
}),
})
);
});
});

Expand Down
Loading

0 comments on commit 542d72b

Please sign in to comment.